Skip to content

[3.6] bpo-35133: Fix mistakes when concatenate string literals on different lines. (GH-10284)#10335

Merged
serhiy-storchaka merged 1 commit into
python:3.6from
serhiy-storchaka:backport-34fd4c2-3.6
Nov 5, 2018
Merged

[3.6] bpo-35133: Fix mistakes when concatenate string literals on different lines. (GH-10284)#10335
serhiy-storchaka merged 1 commit into
python:3.6from
serhiy-storchaka:backport-34fd4c2-3.6

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 5, 2018

Copy link
Copy Markdown
Member

Two kind of mistakes:

  1. Missed space. After concatenating there is no space between words.

  2. Missed comma. Causes unintentional concatenating in a list of strings..
    (cherry picked from commit 34fd4c2)

https://bugs.python.org/issue35133

…ferent lines. (pythonGH-10284)

Two kind of mistakes:

1. Missed space. After concatenating there is no space between words.

2. Missed comma. Causes unintentional concatenating in a list of strings..
(cherry picked from commit 34fd4c2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-34fd4c2-3.6 branch November 5, 2018 15:13
@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7054e5c80b6e98cd44e22d1bc2d7f0a94343089d 2.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 5, 2018
…ferent lines. (pythonGH-10284) (pythonGH-10335)

Two kind of mistakes:

1. Missed space. After concatenating there is no space between words.

2. Missed comma. Causes unintentional concatenating in a list of strings..
(cherry picked from commit 34fd4c2).
(cherry picked from commit 7054e5c)
@bedevere-bot

Copy link
Copy Markdown

GH-10336 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit that referenced this pull request Nov 5, 2018
…ferent lines. (GH-10284) (GH-10335) (GH-10336)

Two kind of mistakes:

1. Missed space. After concatenating there is no space between words.

2. Missed comma. Causes unintentional concatenating in a list of strings.
(cherry picked from commit 34fd4c2)
(cherry picked from commit 7054e5c)
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants